refactor prepared_statements helper #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorbros
approved these changes
Nov 8, 2022
benbromhead
approved these changes
Nov 8, 2022
rukai
force-pushed
the
refactor_execute_prepared
branch
2 times, most recently
from
143f9e0
to
2d90f8a
Compare
|
Converted to draft until we land the required scylla-driver upstream changes |
rukai
force-pushed
the
refactor_execute_prepared
branch
6 times, most recently
from
98b48e2
to
0470b66
Compare
rukai
force-pushed
the
refactor_execute_prepared
branch
from
0470b66
to
c4e2536
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepared_statements now takes a list of values which can be of any cassandra supported type. This will allow for better test coverage.
I will follow this up with a PR that adds a test case which tests every cassandra type in prepared statements.