cassandra_int_tests test node up #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
cassandra_int_test_node_up
branch
from
43edfa9
to
9d341b5
Compare
rukai
force-pushed
the
cassandra_int_test_node_up
branch
from
9d341b5
to
a3823ba
Compare
conorbros
reviewed
Nov 21, 2022
conorbros
approved these changes
Nov 21, 2022
XA21X
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prereq: #917
Instead of changing tmpfs to volume, we could make a separate cassandra-cluster-v4/docker-compose.yaml for persistent tests but it doesn't seem worth it yet.
The
cassandra.yamlchanges are needed to make the cassandra nodes persistent on restart, not sure why they fix the problem but I have verified that they do not cause any regressions in test runtime.The new integration test discovered a bug in
node_pool.rswhere we were accidentally copying over dead connections, so this PR fixes that as well.