New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc cleanup #934

Merged

rukai merged 2 commits into shotover:main from rukai:misc_cleanup

Nov 24, 2022

Member

rukai commented Nov 23, 2022

Bunch of things that were bothering me while working on other PRs.

server.rs comments are left over from when it was copied from a tokio example.
tests should unwrap rather than returning errors.
tokio::spawn is internally just Handle::current().spawn


misc cleanup

669632e

conorbros approved these changes

View reviewed changes

XA21X approved these changes

View reviewed changes


Merge branch 'main' into misc_cleanup

c7fbd99

rukai enabled auto-merge (squash)

November 24, 2022 05:14

rukai merged commit 49217b4 into shotover:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment