test_metrics: make it easier to understand failures #939
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly a bit overengineered but I just could not figure out what I was supposed to change in the expected data to make the test pass in the old implementation.
This PR gives us:
It seems like since the test was originally written the metrics fields within a line have been changed to be alphabetically sorted, this makes our job a lot easier and allows us to assert that entire keys are included in the metrics output.
prereq to: #933