Remove Clone from Transforms enum #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
remove_clone_from_transforms_enum
branch
from
f57f610
to
43b663b
Compare
rukai
force-pushed
the
remove_clone_from_transforms_enum
branch
from
43b663b
to
70e1444
Compare
conorbros
approved these changes
Dec 14, 2022
benbromhead
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prereq: #960Many transforms have kept their Clone implementation as they need it to act as their
build()implementation for now.This PR just removes Clone from the Transforms enum and then fixes any compiler issues brought about from that.