Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move connection helpers into test_helpers #967

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

rukai
Copy link
Member

@rukai rukai commented Dec 19, 2022

A step towards eliminating the #[path = "../../tests/helpers/mod.rs"] hack.

The CassandraConnection type and redis connection helper functions have been moved into a new module named: test_helpers::connection

The redis TLS helper relied on some shotover internals.
I've reimplemented that logic directly into the test to remove that dependency.

Some extra benefits:

  • Allows removal of all the #[allow(dead_code)] annotations because the code is now in a regular old library crate instead of hacked in with #[path = ".."]
  • I suspect it will allow us to work around the "dev-dependencies can not be optional" problem that is preventing us from making cassandra-cpp an optional dependency (but needs some extra work that I've left out of this PR)

@rukai rukai force-pushed the move_connection_logic_into_test_helpers branch from 1adb68f to 0a5237d Compare December 19, 2022 05:36
@rukai rukai force-pushed the move_connection_logic_into_test_helpers branch from b086cd3 to 88047d5 Compare December 20, 2022 06:42
@rukai rukai merged commit 70bde14 into shotover:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants