Move connection helpers into test_helpers #967
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A step towards eliminating the
#[path = "../../tests/helpers/mod.rs"]
hack.The CassandraConnection type and redis connection helper functions have been moved into a new module named:
test_helpers::connection
The redis TLS helper relied on some shotover internals.
I've reimplemented that logic directly into the test to remove that dependency.
Some extra benefits:
#[allow(dead_code)]
annotations because the code is now in a regular old library crate instead of hacked in with#[path = ".."]
cassandra-cpp
an optional dependency (but needs some extra work that I've left out of this PR)