Fix empty shotover_chain_latency metric #980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the registered shotover_chain_latency metric cant specify the client ip it ends up as a separate metric that is always
0
which is quite confusing.e.g.
So instead lets just remove the register to avoid that.
Additionally process_request_rev was failing to specify the client_details which would have also been recorded in a separate metric.
An alternate approach would be to just remove the client_details from the metric but I assume that splitting the metrics up by client is useful?