Add EventMatcher::with_message_regex #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
add_with_message_regex
branch
2 times, most recently
from
f6dbbf8
to
1775b34
Compare
rukai
force-pushed
the
add_with_message_regex
branch
from
1775b34
to
a76bba5
Compare
ronycsdu
approved these changes
Oct 9, 2024
justinweng-instaclustr
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on shotover/shotover-proxy#1762 we found need for more powerful string matching.
I think its important for the default matcher to not use regex, we dont want punctuation to be misinterpreted as regex special characters.
But allowing the user to opt into regex via a method with regex in the name seems appropriate and powerful.