Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anchor tags always open in same tab #249

Closed
arpanchaudhury opened this issue Mar 26, 2016 · 1 comment
Closed

Anchor tags always open in same tab #249

arpanchaudhury opened this issue Mar 26, 2016 · 1 comment

Comments

@arpanchaudhury
Copy link

I want all anchor tags in the parsed markdown to open in a new tab window. I changed showdown.js
file line no 1134 to add target='_blank'. I want to pass one more optional parameter while parsing the markdown to get target attribute of a link. Is it a good idea? If yes, I can add a PR to this.
@arpanchaudhury
Copy link
Author

Closing the issue. Duplicate of #222

@tivie tivie mentioned this issue Feb 3, 2017
Closed
@tivie tivie mentioned this issue Mar 18, 2017
Closed
tivie added a commit that referenced this issue Mar 30, 2017
@tivie
feat(openLinksInNewWindow): add option to open all links in a new window
50235d6 
Closes #362, #337, #249, #247, #222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arpanchaudhury