Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More hardy node environment check #123

Closed
wants to merge 1 commit into from

Conversation

blakeembrey
Copy link

Checking only module is causing issues with other modules in a browser. The actual issue is caused when testing with angular which added a module function to the browser. This module then adds a module.exports property. Finally, another module that checks both thinks we're in node and tries to do a require for additional data.

@tivie
Copy link
Member

tivie commented May 23, 2015

Fixed at eae5f0e

@tivie tivie closed this May 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants