showpad · vlakken · Sep 24, 2023 · Sep 4, 2023 · Sep 4, 2023 · Sep 4, 2023
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -10,7 +10,7 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 

diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
@@ -18,7 +18,7 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 

diff --git a/.github/workflows/publish_website.yml b/.github/workflows/publish_website.yml
@@ -13,7 +13,7 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 

diff --git a/.stylelintrc b/.stylelintrc
@@ -7,6 +7,7 @@
     "prettier/prettier": true,
 
     "block-no-empty": true,
+    "declaration-block-no-duplicate-properties": true,
     "declaration-block-no-redundant-longhand-properties": true,
     "declaration-property-value-disallowed-list": {
       "float": ["inline-start", "inline-end"]

diff --git a/external/builder/builder.mjs b/external/builder/builder.mjs
@@ -42,6 +42,12 @@ function preprocess(inFilename, outFilename, defines) {
     return content.replaceAll(
       /^\s*@import\s+url\(([^)]+)\);\s*$/gm,
       function (all, url) {
+        if (defines.GECKOVIEW) {
+          switch (url) {
+            case "annotation_editor_layer_builder.css":
+              return "";
+          }
+        }
         const file = path.join(path.dirname(baseUrl), url);
         const imported = fs.readFileSync(file, "utf8").toString();
         return expandCssImports(imported, file);

diff --git a/gulpfile.mjs b/gulpfile.mjs
@@ -212,7 +212,7 @@ function createWebpackConfig(
     : [
         [
           "@babel/preset-env",
-          { corejs: "3.32.1", shippedProposals: true, useBuiltIns: "usage" },
+          { corejs: "3.32.2", shippedProposals: true, useBuiltIns: "usage" },
         ],
       ];
   const babelPlugins = ["@babel/plugin-transform-modules-commonjs"];
@@ -244,6 +244,7 @@ function createWebpackConfig(
     "display-svg": "src/display/stubs.js",
   };
   const viewerAlias = {
+    "web-alt_text_manager": "web/alt_text_manager.js",
     "web-annotation_editor_params": "web/annotation_editor_params.js",
     "web-com": "",
     "web-pdf_attachment_viewer": "web/pdf_attachment_viewer.js",
@@ -1353,6 +1354,7 @@ gulp.task(
       console.log();
       console.log("### Building mozilla-central extension");
       const defines = builder.merge(DEFINES, { MOZCENTRAL: true });
+      const gvDefines = builder.merge(defines, { GECKOVIEW: true });
 
       const MOZCENTRAL_DIR = BUILD_DIR + "mozcentral/",
         MOZCENTRAL_EXTENSION_DIR = MOZCENTRAL_DIR + "browser/extensions/pdfjs/",
@@ -1404,7 +1406,7 @@ gulp.task(
         preprocessHTML("web/viewer.html", defines).pipe(
           gulp.dest(MOZCENTRAL_CONTENT_DIR + "web")
         ),
-        preprocessHTML("web/viewer-geckoview.html", defines).pipe(
+        preprocessHTML("web/viewer-geckoview.html", gvDefines).pipe(
           gulp.dest(MOZCENTRAL_CONTENT_DIR + "web")
         ),
 
@@ -1413,7 +1415,7 @@ gulp.task(
           .pipe(replaceMozcentralCSS())
           .pipe(gulp.dest(MOZCENTRAL_CONTENT_DIR + "web")),
 
-        preprocessCSS("web/viewer-geckoview.css", defines)
+        preprocessCSS("web/viewer-geckoview.css", gvDefines)
           .pipe(postcss([autoprefixer(MOZCENTRAL_AUTOPREFIXER_CONFIG)]))
           .pipe(replaceMozcentralCSS())
           .pipe(gulp.dest(MOZCENTRAL_CONTENT_DIR + "web")),

diff --git a/l10n/cs/viewer.properties b/l10n/cs/viewer.properties
@@ -246,9 +246,6 @@ editor_free_text2_label=Text
 editor_ink2.title=Kreslení
 editor_ink2_label=Kreslení
 
-editor_stamp.title=Přidat obrázek
-editor_stamp_label=Přidat obrázek
-
 editor_stamp1.title=Přidání či úprava obrázků
 editor_stamp1_label=Přidání či úprava obrázků
 
@@ -268,3 +265,20 @@ editor_stamp_add_image.title=Přidat obrázek
 editor_free_text2_aria_label=Textový editor
 editor_ink2_aria_label=Editor kreslení
 editor_ink_canvas_aria_label=Uživatelem vytvořený obrázek
+
+# Alt-text dialog
+# LOCALIZATION NOTE (editor_alt_text_button_label): Alternative text (alt text) helps
+# when people can't see the image.
+editor_alt_text_button_label=Náhradní popis
+editor_alt_text_edit_button_label=Upravit náhradní popis
+editor_alt_text_dialog_label=Vyberte možnost
+editor_alt_text_dialog_description=Náhradní popis pomáhá, když lidé obrázek nevidí nebo když se nenačítá.
+editor_alt_text_add_description_label=Přidat popis
+editor_alt_text_add_description_description=Snažte se o 1-2 věty, které popisují předmět, prostředí nebo činnosti.
+editor_alt_text_mark_decorative_label=Označit jako dekorativní
+editor_alt_text_mark_decorative_description=Používá se pro okrasné obrázky, jako jsou rámečky nebo vodoznaky.
+editor_alt_text_cancel_button=Zrušit
+editor_alt_text_save_button=Uložit
+editor_alt_text_decorative_tooltip=Označen jako dekorativní
+# This is a placeholder for the alt text input area
+editor_alt_text_textarea.placeholder=Například: “Mladý muž si sedá ke stolu, aby se najedl.”
diff --git a/l10n/dsb/viewer.properties b/l10n/dsb/viewer.properties
@@ -246,9 +246,6 @@ editor_free_text2_label=Tekst
 editor_ink2.title=Kresliś
 editor_ink2_label=Kresliś
 
-editor_stamp.title=Wobraz pśidaś
-editor_stamp_label=Wobraz pśidaś
-
 editor_stamp1.title=Wobraze pśidaś abo wobźěłaś
 editor_stamp1_label=Wobraze pśidaś abo wobźěłaś
 
@@ -268,3 +265,20 @@ editor_stamp_add_image.title=Wobraz pśidaś
 editor_free_text2_aria_label=Tekstowy editor
 editor_ink2_aria_label=Kresleński editor
 editor_ink_canvas_aria_label=Wobraz napórany wót wužywarja
+
+# Alt-text dialog
+# LOCALIZATION NOTE (editor_alt_text_button_label): Alternative text (alt text) helps
+# when people can't see the image.
+editor_alt_text_button_label=Alternatiwny tekst
+editor_alt_text_edit_button_label=Alternatiwny tekst wobźěłaś
+editor_alt_text_dialog_label=Nastajenje wubraś
+editor_alt_text_dialog_description=Alternatiwny tekst pomaga, gaž luźe njamógu wobraz wiźeś abo gaž se wobraz njezacytajo.
+editor_alt_text_add_description_label=Wopisanje pśidaś
+editor_alt_text_add_description_description=Pišćo 1 sadu abo 2 saźe, kótarejž temu, nastajenje abo akcije wopisujotej.
+editor_alt_text_mark_decorative_label=Ako dekoratiwny markěrowaś
+editor_alt_text_mark_decorative_description=To se za pyšnjece wobraze wužywa, na pśikład ramiki abo wódowe znamjenja.
+editor_alt_text_cancel_button=Pśetergnuś
+editor_alt_text_save_button=Składowaś
+editor_alt_text_decorative_tooltip=Ako dekoratiwny markěrowany
+# This is a placeholder for the alt text input area
+editor_alt_text_textarea.placeholder=Na pśikład, „Młody muski za blidom sejźi, aby jěź jědł“
diff --git a/l10n/en-CA/viewer.properties b/l10n/en-CA/viewer.properties
@@ -41,9 +41,17 @@ print.title=Print
 print_label=Print
 save.title=Save
 save_label=Save
-
+# LOCALIZATION NOTE (download_button.title): used in Firefox for Android as a tooltip for the download button (“download” is a verb).
+download_button.title=Download
+# LOCALIZATION NOTE (download_button_label): used in Firefox for Android as a label for the download button (“download” is a verb).
+# Length of the translation matters since we are in a mobile context, with limited screen estate.
+download_button_label=Download
 bookmark1.title=Current Page (View URL from Current Page)
 bookmark1_label=Current Page
+# LOCALIZATION NOTE (open_in_app.title): This string is used in Firefox for Android.
+open_in_app.title=Open in app
+# LOCALIZATION NOTE (open_in_app_label): This string is used in Firefox for Android. Length of the translation matters since we are in a mobile context, with limited screen estate.
+open_in_app_label=Open in app
 
 # Secondary toolbar and context menu
 tools.title=Tools
@@ -212,7 +220,6 @@ loading_error=An error occurred while loading the PDF.
 invalid_file_error=Invalid or corrupted PDF file.
 missing_file_error=Missing PDF file.
 unexpected_response_error=Unexpected server response.
-
 rendering_error=An error occurred while rendering the page.
 
 # LOCALIZATION NOTE (annotation_date_string): "{{date}}" and "{{time}}" will be
@@ -239,6 +246,12 @@ editor_free_text2_label=Text
 editor_ink2.title=Draw
 editor_ink2_label=Draw
 
+editor_stamp.title=Add an image
+editor_stamp_label=Add an image
+
+editor_stamp1.title=Add or edit images
+editor_stamp1_label=Add or edit images
+
 free_text2_default_content=Start typing…
 
 # Editor Parameters
@@ -248,6 +261,9 @@ editor_ink_color=Colour
 editor_ink_thickness=Thickness
 editor_ink_opacity=Opacity
 
+editor_stamp_add_image_label=Add image
+editor_stamp_add_image.title=Add image
+
 # Editor aria
 editor_free_text2_aria_label=Text Editor
 editor_ink2_aria_label=Draw Editor

diff --git a/l10n/en-GB/viewer.properties b/l10n/en-GB/viewer.properties
@@ -246,9 +246,6 @@ editor_free_text2_label=Text
 editor_ink2.title=Draw
 editor_ink2_label=Draw
 
-editor_stamp.title=Add an image
-editor_stamp_label=Add an image
-
 editor_stamp1.title=Add or edit images
 editor_stamp1_label=Add or edit images
 
@@ -268,3 +265,20 @@ editor_stamp_add_image.title=Add image
 editor_free_text2_aria_label=Text Editor
 editor_ink2_aria_label=Draw Editor
 editor_ink_canvas_aria_label=User-created image
+
+# Alt-text dialog
+# LOCALIZATION NOTE (editor_alt_text_button_label): Alternative text (alt text) helps
+# when people can't see the image.
+editor_alt_text_button_label=Alt text
+editor_alt_text_edit_button_label=Edit alt text
+editor_alt_text_dialog_label=Choose an option
+editor_alt_text_dialog_description=Alt text (alternative text) helps when people can’t see the image or when it doesn’t load.
+editor_alt_text_add_description_label=Add a description
+editor_alt_text_add_description_description=Aim for 1-2 sentences that describe the subject, setting, or actions.
+editor_alt_text_mark_decorative_label=Mark as decorative
+editor_alt_text_mark_decorative_description=This is used for ornamental images, like borders or watermarks.
+editor_alt_text_cancel_button=Cancel
+editor_alt_text_save_button=Save
+editor_alt_text_decorative_tooltip=Marked as decorative
+# This is a placeholder for the alt text input area
+editor_alt_text_textarea.placeholder=For example, “A young man sits down at a table to eat a meal”
diff --git a/l10n/en-US/viewer.properties b/l10n/en-US/viewer.properties
@@ -263,3 +263,20 @@ editor_stamp_add_image.title=Add image
 editor_free_text2_aria_label=Text Editor
 editor_ink2_aria_label=Draw Editor
 editor_ink_canvas_aria_label=User-created image
+
+# Alt-text dialog
+# LOCALIZATION NOTE (editor_alt_text_button_label): Alternative text (alt text) helps
+# when people can't see the image.
+editor_alt_text_button_label=Alt text
+editor_alt_text_edit_button_label=Edit alt text
+editor_alt_text_dialog_label=Choose an option
+editor_alt_text_dialog_description=Alt text (alternative text) helps when people can’t see the image or when it doesn’t load.
+editor_alt_text_add_description_label=Add a description
+editor_alt_text_add_description_description=Aim for 1-2 sentences that describe the subject, setting, or actions.
+editor_alt_text_mark_decorative_label=Mark as decorative
+editor_alt_text_mark_decorative_description=This is used for ornamental images, like borders or watermarks.
+editor_alt_text_cancel_button=Cancel
+editor_alt_text_save_button=Save
+editor_alt_text_decorative_tooltip=Marked as decorative
+# This is a placeholder for the alt text input area
+editor_alt_text_textarea.placeholder=For example, “A young man sits down at a table to eat a meal”
diff --git a/l10n/es-AR/viewer.properties b/l10n/es-AR/viewer.properties
@@ -246,9 +246,6 @@ editor_free_text2_label=Texto
 editor_ink2.title=Dibujar
 editor_ink2_label=Dibujar
 
-editor_stamp.title=Agregar una imagen
-editor_stamp_label=Agregar una imagen
-
 editor_stamp1.title=Agregar o editar imágenes
 editor_stamp1_label=Agregar o editar imágenes
 
@@ -268,3 +265,20 @@ editor_stamp_add_image.title=Agregar una imagen
 editor_free_text2_aria_label=Editor de texto
 editor_ink2_aria_label=Editor de dibujos
 editor_ink_canvas_aria_label=Imagen creada por el usuario
+
+# Alt-text dialog
+# LOCALIZATION NOTE (editor_alt_text_button_label): Alternative text (alt text) helps
+# when people can't see the image.
+editor_alt_text_button_label=Texto alternativo
+editor_alt_text_edit_button_label=Editar el texto alternativo
+editor_alt_text_dialog_label=Eligir una opción
+editor_alt_text_dialog_description=El texto alternativo (texto alternativo) ayuda cuando las personas no pueden ver la imagen o cuando no se carga.
+editor_alt_text_add_description_label=Agregar una descripción
+editor_alt_text_add_description_description=Intente escribir 1 o 2 oraciones que describan el tema, el entorno o las acciones.
+editor_alt_text_mark_decorative_label=Marcar como decorativo
+editor_alt_text_mark_decorative_description=Esto se usa para imágenes ornamentales, como bordes o marcas de agua.
+editor_alt_text_cancel_button=Cancelar
+editor_alt_text_save_button=Guardar
+editor_alt_text_decorative_tooltip=Marcado como decorativo
+# This is a placeholder for the alt text input area
+editor_alt_text_textarea.placeholder=Por ejemplo: “Un joven se sienta a la mesa a comer”
diff --git a/l10n/es-CL/viewer.properties b/l10n/es-CL/viewer.properties
@@ -246,9 +246,6 @@ editor_free_text2_label=Texto
 editor_ink2.title=Dibujar
 editor_ink2_label=Dibujar
 
-editor_stamp.title=Añadir una imagen
-editor_stamp_label=Añadir una imagen
-
 editor_stamp1.title=Añadir o editar imágenes
 editor_stamp1_label=Añadir o editar imágenes
 
@@ -268,3 +265,20 @@ editor_stamp_add_image.title=Añadir imagen
 editor_free_text2_aria_label=Editor de texto
 editor_ink2_aria_label=Editor de dibujos
 editor_ink_canvas_aria_label=Imagen creada por el usuario
+
+# Alt-text dialog
+# LOCALIZATION NOTE (editor_alt_text_button_label): Alternative text (alt text) helps
+# when people can't see the image.
+editor_alt_text_button_label=Texto alternativo
+editor_alt_text_edit_button_label=Editar texto alternativo
+editor_alt_text_dialog_label=Elige una opción
+editor_alt_text_dialog_description=El texto alternativo (alt text) ayuda cuando las personas no pueden ver la imagen o cuando no se carga.
+editor_alt_text_add_description_label=Añade una descripción
+editor_alt_text_add_description_description=Intenta escribir 1 o 2 oraciones que describan el tema, el ambiente o las acciones.
+editor_alt_text_mark_decorative_label=Marcar como decorativa
+editor_alt_text_mark_decorative_description=Se utiliza para imágenes ornamentales, como bordes o marcas de agua.
+editor_alt_text_cancel_button=Cancelar
+editor_alt_text_save_button=Guardar
+editor_alt_text_decorative_tooltip=Marcada como decorativa
+# This is a placeholder for the alt text input area
+editor_alt_text_textarea.placeholder=Por ejemplo: “Un joven se sienta a la mesa a comer”
diff --git a/l10n/es-ES/viewer.properties b/l10n/es-ES/viewer.properties
@@ -41,6 +41,11 @@ print.title=Imprimir
 print_label=Imprimir
 save.title=Guardar
 save_label=Guardar
+# LOCALIZATION NOTE (download_button.title): used in Firefox for Android as a tooltip for the download button (“download” is a verb).
+download_button.title=Descargar
+# LOCALIZATION NOTE (download_button_label): used in Firefox for Android as a label for the download button (“download” is a verb).
+# Length of the translation matters since we are in a mobile context, with limited screen estate.
+download_button_label=Descargar
 bookmark1.title=Página actual (Ver URL de la página actual)
 bookmark1_label=Página actual
 # LOCALIZATION NOTE (open_in_app.title): This string is used in Firefox for Android.
@@ -244,6 +249,9 @@ editor_ink2_label=Dibujar
 editor_stamp.title=Añadir una imagen
 editor_stamp_label=Añadir una imagen
 
+editor_stamp1.title=Añadir o editar imágenes
+editor_stamp1_label=Añadir o editar imágenes
+
 free_text2_default_content=Empezar a escribir…
 
 # Editor Parameters
@@ -253,6 +261,9 @@ editor_ink_color=Color
 editor_ink_thickness=Grosor
 editor_ink_opacity=Opacidad
 
+editor_stamp_add_image_label=Añadir imagen
+editor_stamp_add_image.title=Añadir imagen
+
 # Editor aria
 editor_free_text2_aria_label=Editor de texto
 editor_ink2_aria_label=Editor de dibujos

diff --git a/l10n/eu/viewer.properties b/l10n/eu/viewer.properties
@@ -246,9 +246,6 @@ editor_free_text2_label=Testua
 editor_ink2.title=Marrazkia
 editor_ink2_label=Marrazkia
 
-editor_stamp.title=Gehitu irudia
-editor_stamp_label=Gehitu irudia
-
 editor_stamp1.title=Gehitu edo editatu irudiak
 editor_stamp1_label=Gehitu edo editatu irudiak
 
@@ -268,3 +265,20 @@ editor_stamp_add_image.title=Gehitu irudia
 editor_free_text2_aria_label=Testu-editorea
 editor_ink2_aria_label=Marrazki-editorea
 editor_ink_canvas_aria_label=Erabiltzaileak sortutako irudia
+
+# Alt-text dialog
+# LOCALIZATION NOTE (editor_alt_text_button_label): Alternative text (alt text) helps
+# when people can't see the image.
+editor_alt_text_button_label=Testu alternatiboa
+editor_alt_text_edit_button_label=Editatu testu alternatiboa
+editor_alt_text_dialog_label=Aukeratu aukera
+editor_alt_text_dialog_description=Testu alternatiboak laguntzen du jendeak ezin duenean irudia ikusi edo ez denean kargatzen.
+editor_alt_text_add_description_label=Gehitu azalpena
+editor_alt_text_add_description_description=Saiatu idazten gaia, ezarpena edo ekintzak deskribatzen dituen esaldi 1 edo 2.
+editor_alt_text_mark_decorative_label=Markatu apaingarri gisa
+editor_alt_text_mark_decorative_description=Irudiak apaingarrientzat erabiltzen da, adibidez ertz edo ur-marketarako.
+editor_alt_text_cancel_button=Utzi
+editor_alt_text_save_button=Gorde
+editor_alt_text_decorative_tooltip=Apaingarri gisa markatuta
+# This is a placeholder for the alt text input area
+editor_alt_text_textarea.placeholder=Adibidez, "gizon gaztea mahaian eserita dago bazkaltzeko"