Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix: storybook web error #622

Merged
merged 5 commits into from
Dec 22, 2021
Merged

fix: storybook web error #622

merged 5 commits into from
Dec 22, 2021

Conversation

intergalacticspacehighway
Copy link
Collaborator

@intergalacticspacehighway intergalacticspacehighway commented Dec 22, 2021

Why

  • Fixes the local and probably chromatic web storybook build error.

How

  • As @TatisLois pointed out, storybook web was installing 6.4+ version of @storybook/client-api package and react-native has it pinned to 6.3. I think duplicate packages are causing this issue as mentioned here

Test Plan

Run yarn dev:next-storybook, it should work as expected

@vercel
Copy link

vercel bot commented Dec 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/showtime/showtime/2RwKFSMokerj6w6DAjPDqptni4eF
✅ Preview: https://showtime-git-fix-storybook-showtime.vercel.app

@github-actions
Copy link

github-actions bot commented Dec 22, 2021

PR Preview - Storybook

This pull request preview deployment is now available.

✅ Preview: io.showtime.storybook://expo-development-client/?url=https://exp.host/@tryshowtime/showtime-storybook-react-native/index.exp?release-channel=pr-622&sdkVersion=44.0.0

Comment ID: 999358654

@github-actions
Copy link

github-actions bot commented Dec 22, 2021

PR Preview - App

This pull request preview deployment is now available.

✅ Preview: io.showtime.development://expo-development-client/?url=https://exp.host/@tryshowtime/showtime/index.exp?release-channel=pr-622&sdkVersion=44.0.0

Comment ID: 999362746

@gorhom
Copy link
Contributor

gorhom commented Dec 22, 2021

this PR fixed the issue, well done @intergalacticspacehighway!

@github-actions
Copy link

github-actions bot commented Dec 22, 2021

PR Preview - Storybook on Chromatic

✅ Preview: The Storybook preview URL for this Pull Request

✅ Build: The Chromatic build URL for this Pull Request

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants