Skip to content

Commit

Permalink
{melodic} webrtc: Fix dependency on glib-2.0 and blacklist
Browse files Browse the repository at this point in the history
* fixes:
ERROR: Nothing PROVIDES 'libglib-2.0' (but /jenkins/mjansa/build-ros/ros1-melodic-thud/meta-ros/meta-ros1-melodic/generated-recipes/webrtc-ros/webrtc_59.0.3.bb
DEPENDS on or otherwise requires it). Close matches:
  glib-2.0
NOTE: Runtime target 'webrtc' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['webrtc', 'libglib-2.0']

Signed-off-by: Martin Jansa <martin.jansa@lge.com>
  • Loading branch information
shr-project committed Jul 1, 2020
1 parent 6943f21 commit 0bf278c
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,10 @@ ROS_UNRESOLVED_PLATFORM_PKG_vlc = "vlc"
# Just a package built by geographiclib
ROS_UNRESOLVED_PLATFORM_PKG_geographiclib-tools = "geographiclib-tools"

# Used by:
# generated-recipes/webrtc-ros/webrtc_59.0.3.bb
ROS_UNRESOLVED_PLATFORM_PKG_libglib-dev = "glib-2.0"

#ROS_UNRESOLVED_PLATFORM_PKG_arduino-core = "arduino-core"
ROS_UNRESOLVED_PLATFORM_PKG_bluez = "bluez5"
ROS_UNRESOLVED_PLATFORM_PKG_clang-tidy = "clang-tidy"
Expand All @@ -326,7 +330,6 @@ ROS_UNRESOLVED_PLATFORM_PKG_libftdi-dev = "libftdi"
# with cpp-wrapper PACKAGECONFIG enabled
ROS_UNRESOLVED_PLATFORM_PKG_libftdipp-dev = "libftdi"
#ROS_UNRESOLVED_PLATFORM_PKG_libgeos++-dev = "libgeos++-dev"
ROS_UNRESOLVED_PLATFORM_PKG_libglib-dev = "libglib-2.0"
ROS_UNRESOLVED_PLATFORM_PKG_libgphoto-dev = "libgphoto2"
ROS_UNRESOLVED_PLATFORM_PKG_libgps = "gpsd"
#ROS_UNRESOLVED_PLATFORM_PKG_libgts = "libgts"
Expand Down
12 changes: 12 additions & 0 deletions meta-ros1-melodic/recipes-bbappends/webrtc-ros/webrtc_%.bbappend
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Copyright (c) 2020 LG Electronics, Inc.

# Fetches depot_tools during do_configure and then tries to use vpython which isn't in dependencies
#
# | -- Fetching depot_tools from Chromium
# | Cloning into 'depot_tools'...
# | -- Fetching Ninja build tool
# | -- Fetching WebRTC source code
# | /jenkins/mjansa/build-ros/ros1-melodic-thud/tmp-glibc/work/aarch64-oe-linux/webrtc/59.0.3-r0/git/build/depot_tools/vpython: line 42: /jenkins/mjansa/build-ros/ros1-melodic-thud/tmp-glibc/work/aarch64-oe-linux/webrtc/59.0.3-r0/git/build/depot_tools/.cipd_bin/vpython: No such file or directory
# | CMake Error at CMakeLists.txt:41 (message):
# | cannot fetch WebRTC source code
PNBLACKLIST[webrtc] ?= "Fetches depot_tools during do_configure and then tries to use vpython which isn't in dependencies"
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ RDEPENDS_${PN}_remove = "rosdoc-lite"
RDEPENDS_${PN}_remove = "jackal-tutorials"
RDEPENDS_${PN}_remove = "odom-frame-publisher"

# Fetches depot_tools during do_configure and then tries to use vpython which isn't in dependencies
RDEPENDS_${PN}_remove = "webrtc"

RDEPENDS_${PN}_remove = "${@bb.utils.contains('ROS_WORLD_SKIP_GROUPS', 'qt5', '${ROS_SUPERFLORE_GENERATED_WORLD_PACKAGES_DEPENDING_ON_META_QT5}', '', d)}"

ROS_SUPERFLORE_GENERATED_WORLD_PACKAGES_DEPENDING_ON_META_QT5 = " \
Expand Down

0 comments on commit 0bf278c

Please sign in to comment.