Fixing comments from review #2

shradhasehgal · Mar 30, 2023 · 467d9ab · 467d9ab
1 parent 69145b7
commit 467d9ab
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/docs/api/datasets.rst b/docs/api/datasets.rst
@@ -93,6 +93,11 @@ iNaturalist
 
 .. autoclass:: INaturalist
 
+L8Biome
+^^^^^^^
+
+.. autoclass:: L8Biome
+
 LandCover.ai Geo
 ^^^^^^^^^^^^^^^^
 
@@ -113,7 +118,6 @@ Landsat
 .. autoclass:: Landsat3
 .. autoclass:: Landsat2
 .. autoclass:: Landsat1
-.. autoclass:: L8Biome
 
 NAIP
 ^^^^

diff --git a/docs/api/geo_datasets.csv b/docs/api/geo_datasets.csv
@@ -14,7 +14,7 @@ Dataset,Type,Source,Size (px),Resolution (m)
 `iNaturalist`_,Points,Citizen Scientists,-,-
 `LandCover.ai Geo`_,"Imagery, Masks",Aerial,"4,200--9,500",0.25--0.5
 `Landsat`_,Imagery,Landsat,"8,900x8,900",30
-`L8Biome`_,"Imagery, Masks",Landsat,"8,900x8,900",30
+`L8Biome`_,"Imagery, Masks",Landsat,"8,900x8,900","15,30"
 `NAIP`_,Imagery,Aerial,"6,100x7,600",1
 `Open Buildings`_,Geometries,"Maxar, CNES/Airbus",-,-
 `Sentinel`_,Imagery,Sentinel,"10,000x10,000",10
diff --git a/torchgeo/datamodules/__init__.py b/torchgeo/datamodules/__init__.py
@@ -46,8 +46,8 @@
     "FAIR1MDataModule",
     "GID15DataModule",
     "InriaAerialImageLabelingDataModule",
-    "LandCoverAIDataModule",
     "L8BiomeDataModule",
+    "LandCoverAIDataModule",
     "LoveDADataModule",
     "NASAMarineDebrisDataModule",
     "OSCDDataModule",

diff --git a/torchgeo/datasets/l8biome.py b/torchgeo/datasets/l8biome.py
@@ -25,6 +25,7 @@ class L8Biome(RasterDataset):
 
     Dataset format:
 
+    
     * Each cloud mask is in ENVI binary format.
     Includes all bands from the original Landsat Level-1 data product (GeoTIFF), and its associated Level-1 metadata (MTL.txt file)
 
@@ -37,7 +38,6 @@ class L8Biome(RasterDataset):
     """
 
     url = "https://huggingface.co/datasets/torchgeo/l8biome/blob/main/{}.tar.gz"
-    # redistributed from https://landsat.usgs.gov/landsat-8-cloud-cover-assessment-validation-data
 
     filenames_to_md5 = {
         "barren": "bb446fda3f6af50930849bb135e99f9c",
@@ -59,7 +59,7 @@ class L8Biome(RasterDataset):
     }
 
     filename_glob = "LC*_B2.TIF"
-    targz_file_glob = "*.tar.gz"
+    targz_file_extension = "*.tar.gz"
 
     def __init__(
         self,
@@ -111,7 +111,7 @@ def _verify(self) -> None:
                 return
 
         # Check if the tar.gz files have already been downloaded
-        pathname = os.path.join(self.root, self.targz_file_glob)
+        pathname = os.path.join(self.root, self.targz_file_extension)
         if glob.glob(pathname):
             self._extract()
             return
@@ -137,7 +137,7 @@ def _download(self) -> None:
 
     def _extract(self) -> None:
         """Extract the dataset."""
-        pathname = os.path.join(self.root, self.targz_file_glob)
+        pathname = os.path.join(self.root, self.targz_file_extension)
         for tarfile in glob.iglob(pathname):
             extract_archive(tarfile)