-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SHRINKDESC-125] XML representation for toString() #69
base: master
Are you sure you want to change the base?
Conversation
I'm not quite understanding the issue...looks like this is already covered: Also, this patch has the Exporter API and SPI accepting the Node to be exported, when presumably this would just be a class member anyway? In any case, I've added a commit to trim out some copy/paste artifacts in my own fork of SHRINKDESC-125. Let's see what Jesper says regarding my comment on the issue (I think all the support he needs is already in place). That said, I would like to supply a "toString()" method which accepts a Formatter, such that we can format in a variety of ways (this is already provided for in ShrinkWrap archives, for example). |
My understanding was that he wants to export an individual sub node into an XML string, not just the whole descriptor instance. Feel free to change whatever is needed. I learned a little bit about SPI layer:-) |
Cool, thanks. I've asked Jesper to comment on the issue. |
Updated the issue to reflect the requirements: |
Hi Andrew
I have implemented a NodeExporter very similar to the existing NodeImporter SPI. There is no redundant code which exports a Descriptor or a node. Let me know if you wish changes.
Regards,
Ralf