Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SHRINKRES-320] Resolve control flow issues #184

Merged
merged 2 commits into from
Mar 4, 2024
Merged

[SHRINKRES-320] Resolve control flow issues #184

merged 2 commits into from
Mar 4, 2024

Conversation

petrberan
Copy link
Member

@petrberan petrberan requested a review from xstefank November 29, 2023 16:44
xstefank
xstefank requested changes Nov 30, 2023
View reviewed changes
Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the parentheses, please

...en/src/main/java/org/jboss/shrinkwrap/resolver/api/maven/coordinate/MavenCoordinateImpl.java Outdated
return false;
}
return true;
return (packaging.equals(other.packaging));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outer () not needed

...-maven/src/main/java/org/jboss/shrinkwrap/resolver/api/maven/coordinate/MavenGABaseImpl.java Outdated
}
return true;
return other.groupId == null;
} else return (groupId.equals(other.groupId));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@petrberan
Copy link
Member Author

Fixed everywhere

@petrberan petrberan force-pushed the SHRINKRES-320 branch 2 times, most recently from eb3fce7 to d477dd9 Compare December 1, 2023 14:35
xstefank
xstefank approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petrberan petrberan merged commit 9b436f9 into shrinkwrap:master Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xstefank xstefank xstefank approved these changes

Assignees
No one assigned
Labels
needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petrberan @xstefank