[SHRINKRES-325] Migrating Java language level to Java 8 #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 31, 2024
xstefank
requested changes
Mar 8, 2024
| @@ -67,7 +67,7 @@ private void verifyBuildContent(boolean shouldContain) { | |||
| } | |||
|
|
|||
| private void assertBuildStdoutContains(String expectedString, boolean shouldContain){ | |||
| StringBuffer assertWarn = new StringBuffer("The build output printed on stdout should "); | |||
| StringBuilder assertWarn = new StringBuilder("The build output printed on stdout should "); | |||
There was a problem hiding this comment.
This has nothing to do with JDK version, and it might be intentional if accessed from multiple threads.
There was a problem hiding this comment.
I don't think there's any harm in using the StringBuilder. No other threads are accessing the same instance and StringBuilder should be faster, but in this case I don't mind having the StringBuffer back. Personally, I would keep the StringBuilder
| @@ -32,7 +34,7 @@ public class ConfigurationStageTestCase { | |||
| put("propertyKey1", "propertyValue1"); | |||
| put("propertyKey2", "propertyValue2"); | |||
| }}; | |||
| final Map<String, String> shellEnvironments = new HashMap() {{ | |||
| final Map<String, String> shellEnvironments = new HashMap<String, String>() {{ | |||
There was a problem hiding this comment.
Suggested change
| final Map<String, String> shellEnvironments = new HashMap<String, String>() {{ | |
| final Map<String, String> shellEnvironments = new HashMap<>() {{ |
There was a problem hiding this comment.
This is actually invalid due to the anonymous inner class, new HashMap<>() won't even compile
This would work on JDK 9+, we're still on JDK 8
xstefank
approved these changes
Mar 29, 2024
|
@petrberan needs rebase |
petrberan
force-pushed
the
SHRINKRES-325
branch
from
ed5b02c
to
c567b6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/SHRINKRES-325