Stylistic nits #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Jun 15, 2021
| @@ -72,7 +72,7 @@ The actual updates happen at the end, and the component renders `3`. | |||
|
|
|||
| ## startTransition (opt-in) | |||
|
|
|||
| `startTransition` can be used to mark UI updates that do not need urgent resources for updating. For eg: when typing in a typeahead field, there are two things happening - a blinking cursor that shows visual feedback of your content being typed, and a search functionality in the background that searches for the data that is typed. | |||
| `startTransition` can be used to mark UI updates that do not need urgent resources for updating. For example: when typing in a typeahead field, there are two things happening - a blinking cursor that shows visual feedback of your content being typed, and a search functionality in the background that searches for the data that is typed. | |||
There was a problem hiding this comment.
e.g. already stands for "for example": https://www.merriam-webster.com/dictionary/e.g.
eps1lon
commented
Jun 15, 2021
| @@ -5,7 +5,7 @@ | |||
| Let's take a look at the major new features of React 18: | |||
|
|
|||
| ## Root API (new feature) | |||
| React 18 introduces Root API `ReactDOM.createRoot`. Before React 18, we used `ReactDOM.render` to render a component to the page. Going forward with React 18, we will use ReactDOM.createRoot to create a root, and then pass the root to the render function. The good news is that your current code with `ReactDOM.render` will still work, however, it is recommended to start transitioning to `createRoot` as `render` will be marked `deprecated` starting React 18. | |||
| React 18 introduces a new Root API: `ReactDOM.createRoot`. Before React 18, we used `ReactDOM.render` to render a component to the page. Going forward with React 18, we will use `ReactDOM.createRoot` to create a root, and then pass the component to the render function. The good news is that your current code with `ReactDOM.render` will still work, however, it is recommended to start transitioning to `createRoot` as `render` will be marked `deprecated` starting React 18. | |||
There was a problem hiding this comment.
first you say "ReactDOM.render to render a component" then "pass the root to the render function" and below in the demo you added the comment "//render app to root". The three different wordings might be confusing. So I suggested making it consistent with "pass component to render" across the board.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some stylistic nitpicks I found when reading. Feel free to toss out everything that you don't agree with.