Allow usage on wasm32-unknown-unknown target #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a syscall to the time API when the result is ignored later anyway. This allows to use the library with default options on wasm32-unknown-unknown, where the unimplemented syscall would panic otherwise.
We can drop the value manually, thus avoiding unwrap on each access.
If either `rayon` is already imported, then `rayon::prelude::*` should always resolve.
Closed
shssoichiro
requested changes
Sep 25, 2019
shssoichiro
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to compile and use OxiPNG on
wasm32-unknown-unknowntarget, thus fixes #157.The changes are described in commit messages, but, as a short summary, two primary fixes are:
Instant::now()inDeadline::newwhen noTimeoutis set. This is required becauseInstant::now()panics onwasm32-unknown-unknown(as it tries to retrieve time, for which there is no generic Wasm syscall implementation), and so allows to initialise OxiPNG with default options (no timeout) while still allowing to use timeout on other platforms.feature = "parallel"is unset. Threads proposal for Wasm is not finalised and will take time to be ready in mainstream implementation, so this is also important for OxiPNG to work on Wasm target.