Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uppercase=false does not lowercase the query #21

Closed
bbstilson opened this issue Jun 29, 2023 · 1 comment · Fixed by #50
Closed

uppercase=false does not lowercase the query #21

bbstilson opened this issue Jun 29, 2023 · 1 comment · Fixed by #50

Comments

@bbstilson
Copy link

Piggy backing off : nrempel/sleek#16

If uppercase is false, the query is not lowercased. Either there should be an explicit flag to lowercase the query, or uppercase = false should lowercase the query.
@wugeer
Copy link
Contributor

wugeer commented Sep 6, 2024

@bbstilson Currently, if uppercase is false, it means that no action will be taken on the query . I have a note to fix this issue, and I'll submit a PR later

@wugeer wugeer mentioned this issue Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: uppercase=false does not lowercase the query wugeer/sqlformat-rs
2 participants
@bbstilson @wugeer