Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--uppercase false does not work #16

Closed
bbstilson opened this issue Jun 29, 2023 · 0 comments · Fixed by #17
Closed

--uppercase false does not work #16

bbstilson opened this issue Jun 29, 2023 · 0 comments · Fixed by #17

Comments

@bbstilson
Copy link
Contributor

No description provided.

This was referenced Jun 29, 2023
Merged
Closed
paul-hansen added a commit to paul-hansen/sleek that referenced this issue Jan 20, 2024
@paul-hansen
Fix --uppercase=false not working
c8d6861 
Closes nrempel#16
Fixes the value of the uppercase option always being true.
This was due to the design of claps boolean flags which is
discussed here:
clap-rs/clap#1649 (comment)
This PR uses the solution mentioned in the linked comment from
that thread.

Using `require_equals` and `default_missing_value` allows
`sleek --uppercase "queries/*sql"` to still work without
trying to parse the path as the uppercase boolean, reducing
breakage.

Use `--uppercase=false` to disable uppercase, NOT `--uppercase false`.
paul-hansen added a commit to paul-hansen/sleek that referenced this issue Jan 20, 2024
@paul-hansen
Fix --uppercase=false not working
25ecfd4 
Closes nrempel#16
Fixes the value of the uppercase option always being true.
This was due to the design of claps boolean flags which is
discussed here:
clap-rs/clap#1649 (comment)
This PR uses the solution mentioned in the linked comment from
that thread.

Using `require_equals` and `default_missing_value` allows
`sleek --uppercase "queries/*sql"` to still work without
trying to parse the path as the uppercase boolean, reducing
breakage.

Use `--uppercase=false` to disable uppercase, NOT `--uppercase false`.
@paul-hansen paul-hansen mentioned this issue Jan 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

handle uppercase false bbstilson/sleek
Fix --uppercase=false not working paul-hansen/sleek
1 participant
@bbstilson