Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search only shows first entry on lrclib → can be wrong #41

Closed
Irgendeinwer opened this issue Oct 15, 2024 · 2 comments
Closed

Search only shows first entry on lrclib → can be wrong #41

Irgendeinwer opened this issue Oct 15, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Irgendeinwer
Copy link
Contributor

Hi! When searching for a song that has multiple lyrics on lrclib.net the app just picks the first one. But there are some cases where this returns the wrong lyrics, even though the search contained the full name and artist of the song.

I think an optional selection menu for the source could solve this problem :)

lrclib.net

rush-search2.mp4
@shub39
Copy link
Owner

shub39 commented Oct 15, 2024

Got it, the thing is i dont want it to be fully dependent on lrclib because it does not provide metadata like album art. Let me see what i can do

@shub39 shub39 added the bug Something isn't working label Oct 15, 2024
shub39 added a commit that referenced this issue Oct 16, 2024
*Added dialog to correct lyrics for a song from lrclib #41

*Refactored share cards into the same package
@Irgendeinwer
Copy link
Contributor Author

I tried to get the lyrics for the song used in the video again and now it's the right version by default xD I'm using version 2.3.4-beta (newest version on discord)
Screenshot_2024-10-16-13-32-48-990_com.shub39.rush.beta.jpg

The selection menu works great btw Screenshot_2024-10-16-13-35-06-299_com.shub39.rush.beta.jpg

@shub39 shub39 closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants