Update _tags_popover.html.erb #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madeofhuman
reviewed
Mar 20, 2019
| @@ -1,6 +1,7 @@ | |||
| <div class="main_div"> | |||
| <p class="small_heading"> Follow related tags: </p> | |||
| <%= form_with remote: true, url: '/subscribe/multiple/tag' do |f| %> | |||
| <% unless tags.nil? %> | |||
| <% tags.each do |tag| %> | |||
There was a problem hiding this comment.
Hi, @shubhi2000. I know this PR has been closed, but there's a shorter way to check for existence of tags:
<% tags && tags.each do |tag| %>The first tags will return false if tags is nil, and true if it isn't. The && operator tells Ruby to execute the command on the right only if the command on the left returns true
There was a problem hiding this comment.
@madeofhuman I'll take care of it from next time onwards. Thank you so much :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes publiclab#5021 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!