Skip to content

Commit

Permalink
fix: Added missing type (feast-dev#4315)
Browse files Browse the repository at this point in the history
Added missing type

Signed-off-by: Daniele Martinoli <86618610+dmartinol@users.noreply.github.com>
  • Loading branch information
dmartinol authored Jun 25, 2024
1 parent 21deec8 commit 86af60a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 2 additions & 0 deletions sdk/python/feast/diff/registry_diff.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
OnDemandFeatureView as OnDemandFeatureViewProto,
)
from feast.protos.feast.core.OnDemandFeatureView_pb2 import OnDemandFeatureViewSpec
from feast.protos.feast.core.SavedDataset_pb2 import SavedDataset as SavedDatasetProto
from feast.protos.feast.core.StreamFeatureView_pb2 import (
StreamFeatureView as StreamFeatureViewProto,
)
Expand Down Expand Up @@ -109,6 +110,7 @@ def tag_objects_for_keep_delete_update_add(
OnDemandFeatureViewProto,
StreamFeatureViewProto,
ValidationReferenceProto,
SavedDatasetProto,
)


Expand Down
5 changes: 4 additions & 1 deletion sdk/python/feast/feast_object.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@
from .protos.feast.core.FeatureService_pb2 import FeatureServiceSpec
from .protos.feast.core.FeatureView_pb2 import FeatureViewSpec
from .protos.feast.core.OnDemandFeatureView_pb2 import OnDemandFeatureViewSpec
from .protos.feast.core.SavedDataset_pb2 import SavedDatasetSpec
from .protos.feast.core.StreamFeatureView_pb2 import StreamFeatureViewSpec
from .protos.feast.core.ValidationProfile_pb2 import (
ValidationReference as ValidationReferenceProto,
)
from .saved_dataset import ValidationReference
from .saved_dataset import SavedDataset, ValidationReference
from .stream_feature_view import StreamFeatureView

# Convenience type representing all Feast objects
Expand All @@ -28,6 +29,7 @@
FeatureService,
DataSource,
ValidationReference,
SavedDataset,
]

FeastObjectSpecProto = Union[
Expand All @@ -38,4 +40,5 @@
FeatureServiceSpec,
DataSourceProto,
ValidationReferenceProto,
SavedDatasetSpec,
]

0 comments on commit 86af60a

Please sign in to comment.