Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] migrate search from Flexsearch to Pagefind #2569

Merged
merged 35 commits into from
Sep 11, 2024
Merged

[v4] migrate search from Flexsearch to Pagefind #2569

merged 35 commits into from
Sep 11, 2024

Conversation

dimaMachina
Copy link
Collaborator

@dimaMachina dimaMachina commented Dec 5, 2023

closes #2524

todos:

Copy link

changeset-bot bot commented Dec 5, 2023

🦋 Changeset detected

Latest commit: 7c5b6f1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-theme-docs-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 10:02pm
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 10:02pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 10:02pm

Copy link
Contributor

github-actions bot commented Dec 5, 2023

📦 Next.js Bundle Analysis for swr-site

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 150.24 KB (🟢 -8.94 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/es/docs/revalidation 13.5 KB 163.73 KB 46.78% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@Mike-Logit
Copy link

Mike-Logit commented Jun 11, 2024

Is this still being worked on? We're migrating our docs to Nextra but are having the same issues other have mentioned (see #1980) regarding remote content not being indexed and therefore not appearing in the side navigation and via the search box.

We've had to come up with some complex solution involving a prior build step to pull content manually into the app, but this PR sounds like it would solve the need for this.

@nandreau
Copy link

nandreau commented Jul 17, 2024

I agree, it would be great pull request if it was integrated in last version of nextra to make the search works with remote content

@dimaMachina
Copy link
Collaborator Author

no progress for now, probably will be included only in v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants