-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v4] migrate search from Flexsearch to Pagefind #2569
Conversation
🦋 Changeset detectedLatest commit: 7c5b6f1 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
📦 Next.js Bundle Analysis for swr-siteThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Is this still being worked on? We're migrating our docs to Nextra but are having the same issues other have mentioned (see #1980) regarding remote content not being indexed and therefore not appearing in the side navigation and via the search box. We've had to come up with some complex solution involving a prior build step to pull content manually into the app, but this PR sounds like it would solve the need for this. |
I agree, it would be great pull request if it was integrated in last version of nextra to make the search works with remote content |
no progress for now, probably will be included only in v4 |
closes #2524
todos:
fix subresult active statesubheading-anchor
styles https://github.com/shuding/nextra/blob/v3/packages/nextra-theme-docs/css/typesetting-article.css#L25-L27 and search other places bysubheading-anchor
keyword [v3] attach heading anchorid
attribute to heading (like Pagefind do) and fix heading anchor styles whentheme.typesetting: 'article'
is set #3132fix if there is only 1 subresult like currentlyinclude indexing directly in webpack loader instead of"postbuild": "pagefind --site .next/server/pages --output-path .next/static/chunks/pages/pagefind"
frontmatter.searchable
propertysearch.codeblocks