Remove explicit children: typing in BalancerOwnProps
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `children` is inherited from `React.HTMLAttributes<ElementType>` anyway, the re-definition risks conflicts with projects that may extend this type. For example, `react-i18next` allows users to opt-in to extending `children: ...` to allow for variable insertion in its `<Trans>` components: https://github.com/i18next/react-i18next/blob/master/index.d.ts#L47-L57 By removing the `children: ...` specification here in favor of the inherited definition, we allow `react-wrap-balancer`'s children to match any custom overrides of the React types.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
childrenis inherited fromReact.HTMLAttributes<ElementType>anyway, the re-definition risks conflicts with projects that may extend this type.For example,
react-i18nextallows users to opt-in to extendingchildren: ...to allow for variable insertion in its<Trans>components: https://github.com/i18next/react-i18next/blob/master/index.d.ts#L47-L57By removing the
children: ...specification here in favor of the inherited definition, we allowreact-wrap-balancer's children to match any custom overrides of the React types.