Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type definition files #24

Open
kaityhallman opened this issue Jun 17, 2019 · 5 comments
Open

Type definition files #24

kaityhallman opened this issue Jun 17, 2019 · 5 comments

Comments

@kaityhallman
Copy link

My team is using Typescript with this package. Can we have a type definition file?

@shukerullah
Copy link
Owner

Hi, can anyone from your team submit PR? It will be helpful.

pouncyisdead pushed a commit to pouncyisdead/react-geocode that referenced this issue Jan 7, 2020
pouncyisdead pushed a commit to pouncyisdead/react-geocode that referenced this issue Jan 8, 2020
@ziyaddin
Copy link
Collaborator

ziyaddin commented May 7, 2020

@pouncyisdead would you like to submit PR?

@pouncyisdead
Copy link

pouncyisdead commented May 7, 2020 via email

@ziyaddin
Copy link
Collaborator

ziyaddin commented May 9, 2020

It's okay. I think the current state of the type bindings is good enough.

@shukerullah
Copy link
Owner

Hello @kaityhallman and @pouncyisdead,

We've added TypeScript type definitions to the latest version. Could you please test the package with your setup and let us know if everything works as expected? Your feedback is valuable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants