Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): use ratatui::crossterm instead of importing crossterm #16

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

joshka
Copy link
Collaborator

@joshka joshka commented Aug 6, 2024

Alternative to: #15

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.66%. Comparing base (3b9564a) to head (23d0ec0).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   32.66%   32.66%           
=======================================
  Files           1        1           
  Lines         450      450           
=======================================
  Hits          147      147           
  Misses        303      303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shuoli84
Copy link
Owner

shuoli84 commented Aug 6, 2024

I've added a new example in master, that one needs to do same change I guess..

@joshka
Copy link
Collaborator Author

joshka commented Aug 6, 2024

I've added a new example in master, that one needs to do same change I guess..

rebased on main and added

Copy link
Owner

@shuoli84 shuoli84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shuoli84 shuoli84 merged commit 18ac789 into main Aug 6, 2024
10 checks passed
@shuoli84
Copy link
Owner

shuoli84 commented Aug 6, 2024

Thanks!

@github-actions github-actions bot mentioned this pull request Aug 6, 2024
@joshka joshka deleted the jm/crossterm branch August 6, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants