Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document.requestStorageAccess should consider user explicit settings for unpartitioned data access #2

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

shuranhuang
Copy link
Owner

@shuranhuang shuranhuang commented Aug 10, 2023

This change tries to make rSA behavior aligns with hSA and user expectations by including a check of whether the user agent allows the document to access unpartitioned data based on user settings, and move early resolve cases, such as top-level case and same-site case, behind the user settings check. Specifically:

  • For the cases where hSA returns true, calling rSA will not show a prompt.

  • For the cases where hSA returns false, calling rSA may or may not show a prompt:

    • If user settings explicitly disallow unpartitioned data access, calling rSA will resolve with "denied" and not show a prompt.
    • If no user settings exist, calling rSA may either resolve with "granted" depending on heuristics and not show a prompt, or show a prompt when there isn't an existing grant.
  • At least two implementers are interested (and none opposed):

  • Tests are written and can be reviewed and commented upon at:

  • Implementation bugs are filed:

@shuranhuang shuranhuang changed the title Export the algo that gets user agent explicitly settings for unpartitioned cookie document.requestStorageAccess should consider user explicitly settings for unpartitioned data access Aug 10, 2023
@shuranhuang shuranhuang changed the title document.requestStorageAccess should consider user explicitly settings for unpartitioned data access document.requestStorageAccess should consider user explicit settings for unpartitioned data access Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant