🔥added webhook support #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shurco
reviewed
Nov 13, 2023
internal/queries/cart.go
Outdated
Comment on lines
132
to
147
|
|
||
| if email.Valid { | ||
| cart.Email = email.String | ||
| } | ||
|
|
||
| if name.Valid { | ||
| cart.Name = name.String | ||
| } | ||
|
|
||
| if paymentID.Valid { | ||
| cart.PaymentID = paymentID.String | ||
| } | ||
|
|
||
| if updated.Valid { | ||
| cart.Updated = updated.Int64 | ||
| } |
There was a problem hiding this comment.
I think that validating data from the database here is unnecessary.
By logic - when we write data to the database, we validate them, and they should return already valid.
shurco
reviewed
Nov 13, 2023
internal/handlers/public/cart.go
Outdated
| log.Println(err) | ||
| } | ||
|
|
||
| if res.Status != "200 OK" { |
There was a problem hiding this comment.
may be use
Suggested change
| if res.Status != "200 OK" { | |
| if res.StatusCode != 200 { |
shurco
reviewed
Nov 13, 2023
internal/handlers/public/cart.go
Outdated
| if err != nil { | ||
| log.Println(err) | ||
| } | ||
| if res.Status != "200 OK" { |
There was a problem hiding this comment.
Suggested change
| if res.Status != "200 OK" { | |
| if res.StatusCode != 200 { |
|
@msalbrain, good job! |
shurco
reviewed
Nov 13, 2023
internal/handlers/public/cart.go
Outdated
| log.Println(err) | ||
| } | ||
|
|
||
| if res.Status != "200 OK" { |
There was a problem hiding this comment.
Suggested change
| if res.Status != "200 OK" { | |
| if res.StatusCode != 200 { |
|
Thank you very much |
|
looks cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please delete options that are not relevant.
Checklist: