Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xScale parameter to Graph #346

Closed
wants to merge 2 commits into from
Closed

Commits on Nov 13, 2013

  1. Add xScale parameter to Graph

    By creating Rickshaw.Graph({xScale: d3.time.scale()}), users can now
    instantiate a Graph with a linear scale that has Date objects as
    domain values. This way, a regular Axis.X can render time using D3's
    time formatter:
    
        var xAxis = new Rickshaw.Graph.Axis.X({
            graph: graph,
            tickFormat: graph.x.tickFormat()
        });
    rbu committed Nov 13, 2013
    Configuration menu
    Copy the full SHA
    52fdc40 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2013

  1. Ensure Graph creates a copy of the xScale before modifying it

    xScale is coming from the configuration dictionary which may be
    referenced by the Graph creator, or shared with other Graphs. We need to
    ensure we copy the scale so that our mutations do not change the object
    given to us.
    rbu committed Nov 26, 2013
    Configuration menu
    Copy the full SHA
    a326825 View commit details
    Browse the repository at this point in the history