Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: feature-gate OpenSSL dependency #100

Closed
rimutaka opened this issue Mar 23, 2022 · 3 comments
Closed

feature: feature-gate OpenSSL dependency #100

rimutaka opened this issue Mar 23, 2022 · 3 comments
Labels
S-Not Planned We don't have any plans to work on this T-Improvement Improvement or addition to existing features

Comments

@rimutaka
Copy link

sqlx has a dependency on native-tls. Not every environment has OpenSSL and whatever the Win equivalent is. rustls is more interoperable.

    │   │   ├── sqlx-rt v0.5.11
    │   │   │   ├── native-tls v0.2.8
    │   │   │   │   ├── log v0.4.14 (*)
    │   │   │   │   ├── openssl v0.10.38
    │   │   │   │   │   ├── bitflags v1.3.2
    │   │   │   │   │   ├── cfg-if v1.0.0
    │   │   │   │   │   ├── foreign-types v0.3.2
    │   │   │   │   │   │   └── foreign-types-shared v0.1.1
    │   │   │   │   │   ├── libc v0.2.120
    │   │   │   │   │   ├── once_cell v1.10.0
    │   │   │   │   │   └── openssl-sys v0.9.72
    │   │   │   │   │       └── libc v0.2.120
    │   │   │   │   │       [build-dependencies]
    │   │   │   │   │       ├── autocfg v1.1.0
    │   │   │   │   │       ├── cc v1.0.73
    │   │   │   │   │       └── pkg-config v0.3.24
    │   │   │   │   ├── openssl-probe v0.1.5
    │   │   │   │   └── openssl-sys v0.9.72 (*)
    │   │   │   ├── once_cell v1.10.0
    │   │   │   ├── tokio v1.17.0 (*)
    │   │   │   └── tokio-native-tls v0.3.0
    │   │   │       ├── native-tls v0.2.8 (*)
    │   │   │       └── tokio v1.17.0 (*)

https://github.com/getsynth/shuttle/blob/main/api/Cargo.toml#L19 explicitly states

sqlx = { version = "0.5", features = ["runtime-tokio-native-tls", "postgres"] }

which may be for a good reason.

Consider using runtime-tokio-rustls instead

@christos-h christos-h changed the title OpenSSL dependency feature: feature-gate OpenSSL dependency Apr 5, 2022
@christos-h
Copy link
Member

christos-h commented Apr 5, 2022

Hey @rimutaka this is a good point. Is this blocking you currently?

I'm going to add it to our roadmap. We'll use this issue as a general gauge of interest from the community.

@christos-h christos-h moved this to Considering in Feature Requests Roadmap Apr 5, 2022
@christos-h christos-h added T-Improvement Improvement or addition to existing features portability labels Apr 5, 2022
@jonaro00 jonaro00 added S-Not Planned We don't have any plans to work on this and removed portability labels Aug 17, 2023
@jonaro00
Copy link
Member

Not planned at the moment due to cargo-generate not supporting rustls

@jonaro00
Copy link
Member

cargo-shuttle now uses rustls only, and the sqlx-related plugins allow selecting tls implementation via features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Not Planned We don't have any plans to work on this T-Improvement Improvement or addition to existing features
Projects
No open projects
Status: Considering
Development

No branches or pull requests

3 participants