Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Switch shuttle to Rustls #873

Closed
7 tasks done
iamwacko opened this issue May 6, 2023 · 2 comments
Closed
7 tasks done

[Feature]: Switch shuttle to Rustls #873

iamwacko opened this issue May 6, 2023 · 2 comments

Comments

@iamwacko
Copy link
Contributor

iamwacko commented May 6, 2023

Describe the feature

We currently use native-tls everywhere (openssl). This can cause issues for certain users, for example for users with out of date installations of openssl. We should investigate if we can switch to rustls everywhere, and if there are any drawbacks to doing it. If not, we should do it. #100 is similar, but it just wants a feature gate. If this gets resolved native-tls will just be gone.

This is S SB2, and already moved to assigned on the Notion. @oddgrd I need perms for labels and assignments.

Suggestion or Example of how the feature would be used

  • Check if it is possible and works for everyone
  • Implement the changes
    • cargo-edit depends on native-tls
    • reqwest depends on native-tls
    • axum depends on native-tls
    • sqlx depends on native-tls

Duplicate declaration

  • I have searched the issues and this feature has not been requested before.
@iamwacko
Copy link
Contributor Author

iamwacko commented May 7, 2023

cargo-edit seems to use rustls by default, but native-tls is still in the dependency tree because it will use native-tls on platforms rustls doesn't support.

@iamwacko
Copy link
Contributor Author

iamwacko commented May 7, 2023

It looks like we can move away completely from rustls, but bringing in cargo as a dependency means we still have to use openssl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants