-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch from native-tls to rustls #879
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! I'm curious if we will have similar issues with other crates in the future if we don't use native-tls 🤔
By the way we use the vendored-openssl
feature flag in our CI in a few places, this should also be updated. 🙏
#821 strikes again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM except for one small comment!
Still waiting for #888 to remove cargo-edit for this to complete, right? |
Sort of, but not really. native-tls will still show up in the
See line 89 of this. What this means is that in practice native-tls is gone and OpenSSL with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description of change
This PR changes
native-tls
torustl
s on almost all of our dependencies.cargo-edit
still technically depends onnative-tls
, but that is because it usesnative-tls
on architectures unsupported byrustls
. Thanks to our dependency oncargo
OpenSSL is still in the dependency tree, so I will hold off on actually merging this until the cargo library is completely removed, by me or someone else. Closes issue #873.How Has This Been Tested (if applicable)?
It should just work, but I did compile and run it successfully. To check that native-tls wasn't anywhere in the dependency tree I ran
cargo tree --target all -i native-tls
.