Bug Fix: SSL get headers image verification #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug related to Issue shweshi#83 on main repository where after verifying the problem it was determined that SSL marked as Wildcard ( * ) can cause problems with "get_headers" function in php. It was assumed previously that "FILTER_VALIDATE_URL" was being too strict, but later determined that SSL verification was failing.
|
@ItsSkynet Thanks for going deeper into the issue and finding the root cause. Is it possible to add a test case for the same? PR looks okay to me. |
|
of course, at the moment of writing i have found a flaw in the way i approached this and i'm changing it now so that prevents changing of defaults set. i will update this pull request once i'm done changing it. |
Changed Defaults overwrite to a more use-case context values set, sing "stream_context_create" for just this specific function. Get_headers accept a context option to be added into function.
|
i attach here a sandbox test of before and after the change using the before explained issue with twitter images not being read by get_headers |
|
@ItsSkynet is the PR ready to merge? |
yes, its ready. |
|
@ItsSkynet Thanks for your contribution. PR is merged and fix is released with new version. https://github.com/shweshi/OpenGraph/releases/tag/V1.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug related to Issue #83 on main repository where after verifying the problem it was determined that SSL marked as Wildcard ( * ) can cause problems with "get_headers" function in php.
It was assumed previously that "FILTER_VALIDATE_URL" was being too strict, but later determined that SSL verification was failing.