Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a problem where the header only contains 200 #92

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix a problem where the header only contains 200 #92

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f8f2c3
Fix a problem where the header only contains 200
roerlemans Aug 19, 2024
da69f47
Make check more safe
roerlemans Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OpenGraph.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ protected function verify_image_url($url)
]);
$headers = get_headers($url, true, $context_headers);

return stripos($headers[0], '200 OK') ? true : false;
return stripos($headers[0], '200') ? true : false;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roerlemans can we keep checks for both '200 OK' and '200'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the OK-part is not always available in the response. When I check both, it would still fail in the use case I found.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why check on the '200 OK' state when 200 is sufficient? 200 means that the request was received and fullfilled successfully.

Another thing I would suggest to change is, snce stripos($headers[0], '200') could return a 0 which is not false but just the beginning of the string you should do something like:

return stripos($headers[0], '200') !== false ? true, false

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjtbsomhorst I did implement the fix for the beginning of the string. Thanks.

I also agree with the fact that 200 should be sufficient.

} catch (\Exception $e) {
return false;
}
Expand Down