Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clickable logo #211

Merged
merged 2 commits into from
May 25, 2023
Merged

Conversation

CameronSquires
Copy link
Contributor

@CameronSquires CameronSquires commented May 24, 2023

Description

Made devFind paragraph logo clickable

Related Issues

Fixed Issue #207

Changes Proposed

Included hyperlink tag to make the devFind paragraph logo clickable. I have also made this specific link not underlined on hover.

Hyperlink tag added here in .jsx file:


dev


Find


css added to the specific hyperlink tag added here:

a.titlelink:hover {
text-decoration: none;
cursor: pointer;
}

Checklist

  • I have read and followed the Contribution Guidelines.
  • All new and existing tests passed.
  • I have updated the documentation to reflect the changes I've made.
  • My code follows the code style of this project.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Please let me know if there are any issues, concerns or anything that needs modification.
Thanks

@vercel
Copy link

vercel bot commented May 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2023 11:58am

Copy link
Contributor

@MuhammadNoorani MuhammadNoorani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you made the logo clickable, does it re-direct to the home page?

@CameronSquires
Copy link
Contributor Author

@MuhammadNoorani Yes, it re-directs to: https://dev-find.vercel.app/

please see attached for relevant screenshot where it shows the link on bottom left where it re-directs.

devFind2-final

Copy link
Contributor

@MuhammadNoorani MuhammadNoorani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, approving the changes, soon will be merged.

Nice work, always share relevant screenshots and proper description after reading the complete issue, it is a good practice.

Thank You for your valuable contribution.

@CameronSquires
Copy link
Contributor Author

Thank you @MuhammadNoorani for the feedback, it is very much appreciated!

I am glad to have contributed to this project, I am looking forward to seeing it grow.

@shyamtawli
Copy link
Owner

shyamtawli commented May 25, 2023

@CameronSquires Looks good to me. Thanks for the contribution.

bharathkalyans pushed a commit to bharathkalyans/devFind that referenced this pull request May 26, 2023
Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants