-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for jabba exec. #289
base: master
Are you sure you want to change the base?
Conversation
Refactored `use` command to improve usability by introducing a `GetVars` function that returns the functions to be exported for use by `exec`. Implemented an `exec` that simply passes the args as-is to the specified binary via `syscall.Exec`. Fixes shyiko#285
I've taken the liberty of bumping the version in the changelog, hope that's not going to be a problem. Could you let me know when you release the new binary? Hope it's sooner than later :) Thanks. |
@ketan thank you! This looks great. Any chance you would be willing to do something about Windows (syscall.Exec returns EWINDOWS)? Ideally, exec should work on all target OSs. A message showing that it's not supporfted on Windows would work too I suppose. |
Sorry, I did not see |
FYI: |
@ketan I understand. I'm not asking to replace syscall.Exec. It should stay. All we need is runtime.GOOS == "windows" case :). |
To be honest, my motivation of doing |
Up to you. I'm fine with either case. |
Any news about this feature? |
Not a followup of this feature per se, but you could have a look at https://github.com/nicerloop/jabba-wrapper |
Refactored
use
command to improve usability by introducing aGetVars
function that returns the functions to be exported for use by
exec
.Implemented an
exec
that simply passes the args as-is to the specifiedbinary via
syscall.Exec
.Fixes #285