A bug in ByteArrayInputStream

[chenyun]

I think length = bytes.length >> 2 should be length = bytes.length >> 1

    private byte[] reverse(byte[] bytes) {
        for (int i = 0, length = bytes.length >> 2; i <= length; i++) {
            int j = bytes.length - 1 - i;
            byte t = bytes[i];
            bytes[i] = bytes[j];
            bytes[j] = t;
        }
        return bytes;
    }

[shyiko]

That's insane! Thanks a lot for reporting.

[shyiko]

Incorporated in 0.1.3 (which should become available through Maven Central in the next 24h).

[chenyun]

Hi @shyiko , I have a question: what is the purpose of EventDeserializer.Deserializer and EventDataWrapper?

    private void afterEventDataDeserializerSet(EventType eventType) {
        if (eventType == null || eventType == EventType.TABLE_MAP) {
            EventDataDeserializer eventDataDeserializer = getEventDataDeserializer(EventType.TABLE_MAP);
            if (eventDataDeserializer.getClass() != TableMapEventDataDeserializer.class &&
                eventDataDeserializer.getClass() != EventDataWrapper.Deserializer.class) {
                tableMapEventDataDeserializer = new EventDataWrapper.Deserializer(
                    new TableMapEventDataDeserializer(), eventDataDeserializer);
            } else {
                tableMapEventDataDeserializer = null;
            }
        }

why do you pay special care to tableMapEventDataDeserializer in this method?

[shyiko]

@chenyun TABLE_MAP and ROTATE events are used internally by EventDeserializer/BinaryLogClient and thus are required to be deserialized in a specific way regardless whether user specified custom deserializer or not. More on that #29 and #28.