Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the microsecond option uniform across all datetimes #138

Merged
merged 1 commit into from
Dec 26, 2016
Merged

make the microsecond option uniform across all datetimes #138

merged 1 commit into from
Dec 26, 2016

Conversation

osheroff
Copy link
Collaborator

this gives us microsecond precision no matter what.

not a huge fan of the wishy washy name castTimestamp, but it's slightly better than castLongToMicrosecondsMaybe

make the microsecond option uniform across all datetimes
88fc0da 
this gives us microsecond precision no matter if mysql had any idea of
it or not.
@shyiko shyiko mentioned this pull request Dec 26, 2016
Open
@shyiko shyiko merged commit 21d99a4 into shyiko:hotfix-0.7.1 Dec 26, 2016
@shyiko
Copy link
Owner

shyiko commented Dec 26, 2016

@osheroff I'll add tests to make sure stuff like this doesn't happen again in #139.

@shyiko
Copy link
Owner

shyiko commented Dec 26, 2016

@osheroff 0.7.2 deployed to Maven Central.

@osheroff
Copy link
Collaborator Author

thanks @shyiko !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osheroff @shyiko