Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests to TravisCI #238

Closed
wants to merge 1 commit into from
Closed

Add integration tests to TravisCI #238

wants to merge 1 commit into from

Conversation

jonahgeorge
Copy link

Currently there are two failing test cases that seem related to the Java version being run by Travis (running this with oraclejdk8 vs openjdk8 leads to different test failures). Unfortunately, I don't have sufficient knowledge of this library to fix them; however, hopefully this PR at least shows how to execute these tests in CI.

Results :
Failed tests: 
  BinaryLogClientIntegrationTest.testDeserializationOfDateAndTimeAsLong:402->writeAndCaptureRow:478 » IndexOutOfBounds
  JsonBinaryValueIntegrationTest.testScalarNegativeInt32:294->assertJSONMatchOriginal:396->writeAndCaptureJSON:423 » IndexOutOfBounds
Tests run: 79, Failures: 2, Errors: 0, Skipped: 0

@jonahgeorge jonahgeorge deleted the integration-testing branch September 20, 2018 15:47
@shyiko
Copy link
Owner

shyiko commented Sep 20, 2018

Hey @jonahgeorge. Have you closed PR by mistake? I do intend to merge this. Just haven't found the time yet.

@jonahgeorge
Copy link
Author

Apologies! I was just cleaning up older issues / pull requests. I'll reopen 😄

@jonahgeorge jonahgeorge restored the integration-testing branch September 20, 2018 19:06
@jonahgeorge jonahgeorge reopened this Sep 20, 2018
@shyiko
Copy link
Owner

shyiko commented Sep 20, 2018

No worries. Thanks again!

@shyiko shyiko mentioned this pull request Dec 10, 2018
Merged
@jonahgeorge
Copy link
Author

Closing this due to age

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonahgeorge @shyiko