Add mariadb event types #280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinfwhuang
commented
May 31, 2019
| @@ -307,6 +307,10 @@ public EventDataDeserializer getEventDataDeserializer(EventType eventType) { | |||
| return eventDataDeserializer != null ? eventDataDeserializer : defaultEventDataDeserializer; | |||
| } | |||
|
|
|||
| public Map<Long, TableMapEventData> getTableMapEventByTableId() { | |||
| return tableMapEventByTableId; | |||
There was a problem hiding this comment.
This allows user to get the tableMapEventByTableId back from the default EventDeserializer. Whenever a library user wants to selectively override any of the eventDeserializers, the library user would probably need to access this map.
jinfwhuang
force-pushed
the
add-mariadb-event-types
branch
2 times, most recently
from
a06fc37
to
66caf6d
Compare
jinfwhuang
force-pushed
the
add-mariadb-event-types
branch
from
66caf6d
to
c0b1baa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Note:
The main change in this PR is to add support to the library to recognize all of the MariaDB event types. The would allow the library to be used in processing MariaDB binlogs. This PR does not change any of the existing deserialization behaviors. The PR does not add additional deserializations for those new MariaDB events.
The key changes are in
EventType.java.