Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect errors in direct queries #55

Merged
merged 2 commits into from
Jun 30, 2015

Conversation

cmerrick
Copy link
Contributor

Check for ERROR packet in BinaryLogClient.readResultSet() to ensure that function doesn't hang when the user doesn't have the appropriate REPLICATION CLIENT permission.

@shyiko
Copy link
Owner

shyiko commented Jun 30, 2015

Good job! Thanks, man.

P.S. I'm gonna apply some changes to the PR so that you would get nice and clean ServerException("Access denied; you need (at least one of) the SUPER,REPLICATION CLIENT privilege(s) for this operation") instead of IOException("Failed to determine binlog filename/position").

shyiko added a commit that referenced this pull request Jun 30, 2015
Check for error packet in readResultSet
@shyiko shyiko merged commit cdf85f7 into shyiko:master Jun 30, 2015
shyiko added a commit that referenced this pull request Jun 30, 2015
jpechane pushed a commit to jpechane/mysql-binlog-connector-java that referenced this pull request Jan 28, 2022
Add details to the EOF exceptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants