Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hangfire] Add logging statement for starting job execution #29

Closed
fb-smit opened this issue Jan 8, 2024 · 0 comments
Closed

[Hangfire] Add logging statement for starting job execution #29

fb-smit opened this issue Jan 8, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed PiBox.Plugins.Jobs.Hangfire

Comments

@fb-smit
Copy link
Contributor

fb-smit commented Jan 8, 2024

We should also log the starting execution of a job, analog to the finishing of the job see here

pibox/PiBox.Plugins/Jobs/Hangfire/src/PiBox.Plugins.Jobs.Hangfire/Job/AsyncHangfireJob.cs

Line 15 in 9e49344

{

But not include the job parameters bc they can include sensitive info and are serialized in plain text. Or we would need to build a wrapper to encrypt/decrypt them properly before and after.
@fb-smit fb-smit added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jan 8, 2024
fb-smit added a commit that referenced this issue Feb 5, 2024
@fb-smit
(hangfire): #29 log job start and finish
6a0e183
@fb-smit fb-smit closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed PiBox.Plugins.Jobs.Hangfire
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fb-smit