Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/hangfire remove default storages #68

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

tst-sia
Copy link
Contributor

@tst-sia tst-sia commented Jan 24, 2025

Removes default storage configuration from hangfire plugin. Storage configuration is now part of the implementing service's configuration so we don't have to maintain storage connections/compatibility.

Copy link

github-actions bot commented Jan 24, 2025

Test Results

 18 files  ±0   18 suites  ±0   27s ⏱️ +2s
381 tests ±0  374 ✅ ±0  7 💤 ±0  0 ❌ ±0 
382 runs  ±0  375 ✅ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit 4db743c. ± Comparison against base commit 755a7b6.

♻️ This comment has been updated with latest results.

@apurkovic apurkovic self-requested a review January 24, 2025 10:38
@apurkovic
Copy link
Contributor

@tst-sia it seems that the property IHangfireConfigurator.IncludesStorage is not used. I recommend to delete it from the interface.

@tst-sia tst-sia merged commit d421841 into main Jan 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants