Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synchronous DelegateCommand suppresses exception #311

Closed
sideisra opened this issue Oct 29, 2015 · 1 comment
Closed

synchronous DelegateCommand suppresses exception #311

sideisra opened this issue Oct 29, 2015 · 1 comment

Comments

@sideisra
Copy link
Contributor

When using DelegateCommand in synchronous mode (new DelegateCommand(<action supplier definition>);) it runs the action synchronous. I saw in the cod that the call to action is surrounded by try-catch and the caught exception is just printed in the console (e.printStackTrace()) so i have no chance to react on execution problems. It would be better to rethrow the exception as RuntimeException to give the caller a chance to react on it.

@sialcasa
Copy link
Owner

sialcasa commented Nov 2, 2015

ouch - we'll fix

sialcasa added a commit that referenced this issue Nov 3, 2015
@manuel-mauky manuel-mauky added this to the 1.4.1 Bugfix-Release milestone Nov 3, 2015
sialcasa added a commit that referenced this issue Nov 3, 2015
sialcasa added a commit that referenced this issue Nov 3, 2015
sialcasa added a commit that referenced this issue Nov 4, 2015
* develop:
  try to fix upload script
  external snapshot script for travis
  remove by hand install of java
  changed travis java install
  travis will make snapshots for release branch
  travis will make snapshots for release branch
  update version for dev branch to 1.5.0-SNAPSHOT
  #311
  update version to 1.4.1-SNAPSHOT
  #298 some small fixes for the pull request for list mapping
  Fixed compile errors in Eclipse.
  #311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants