Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't update default values when model changes #402

Merged
merged 1 commit into from
Jun 20, 2016
Merged

Don't update default values when model changes #402

merged 1 commit into from
Jun 20, 2016

Conversation

johnp
Copy link
Contributor

@johnp johnp commented Jun 17, 2016

This seems wrong to me. Otoh, if this behavior is intended it should probably be documented.

@johnp
Copy link
Contributor Author

johnp commented Jun 17, 2016 •
edited
Loading

fixed test

@johnp johnp closed this Jun 17, 2016
@johnp johnp reopened this Jun 17, 2016
@manuel-mauky
Copy link
Collaborator

Hi Johannes,
thanks for your PR. You are correct, this is a wrong behaviour that was introduced with #372.

@manuel-mauky manuel-mauky reopened this Jun 20, 2016
@manuel-mauky manuel-mauky added this to the 1.5.1 milestone Jun 20, 2016
@manuel-mauky manuel-mauky merged commit 8c048dc into sialcasa:develop Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@johnp @manuel-mauky