You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While integrating the unishox2 library with the Meshtastic project, the initial PR reported the following errors as part of the linting with tool-cppcheck.
I'll submit a PR to fix this shortly.
Tool Manager: Installing platformio/tool-cppcheck @ ~1.260.0 25
Downloading... 26
Unpacking... 27
Tool Manager: tool-cppcheck @ 1.260.0 has been installed! 28
src/mesh/compression/unishox2.c:132: [low:style] Redundant condition: If 'c > 32', the comparison 'c != 0' is always true. [redundantCondition] 29
src/mesh/compression/unishox2.c:150: [low:style] The scope of the variable 'cur_bit' can be reduced. [variableScope] 30
src/mesh/compression/unishox2.c:151: [low:style] The scope of the variable 'blen' can be reduced. [variableScope] 31
src/mesh/compression/unishox2.c:152: [low:style] The scope of the variable 'a_byte' can be reduced. [variableScope] 32
src/mesh/compression/unishox2.c:153: [low:style] The scope of the variable 'oidx' can be reduced. [variableScope] 33
src/mesh/compression/unishox2.c:979: [low:style] Local variable 'idx' shadows outer variable [shadowVariable]
The text was updated successfully, but these errors were encountered:
mc-hamster
added a commit
to mc-hamster/Unishox2
that referenced
this issue
Apr 14, 2022
Hi @mc-hamster , not related to this issue, but you may want to have a look at this: #47 (comment)
This release (1.0.3) could be used to prevent crashes during decompression due to invalid or garbled inputs that come through unreliable networks.
@siara-cc Thanks for the notification. I don't think this will impact us -- we use the highest level of error correction provided by the lora hardware, but will add the upgrade to the backlog regardless.
While integrating the unishox2 library with the Meshtastic project, the initial PR reported the following errors as part of the linting with tool-cppcheck.
I'll submit a PR to fix this shortly.
Tool Manager: Installing platformio/tool-cppcheck @ ~1.260.0
25
Downloading...
26
Unpacking...
27
Tool Manager: tool-cppcheck @ 1.260.0 has been installed!
28
src/mesh/compression/unishox2.c:132: [low:style] Redundant condition: If 'c > 32', the comparison 'c != 0' is always true. [redundantCondition]
29
src/mesh/compression/unishox2.c:150: [low:style] The scope of the variable 'cur_bit' can be reduced. [variableScope]
30
src/mesh/compression/unishox2.c:151: [low:style] The scope of the variable 'blen' can be reduced. [variableScope]
31
src/mesh/compression/unishox2.c:152: [low:style] The scope of the variable 'a_byte' can be reduced. [variableScope]
32
src/mesh/compression/unishox2.c:153: [low:style] The scope of the variable 'oidx' can be reduced. [variableScope]
33
src/mesh/compression/unishox2.c:979: [low:style] Local variable 'idx' shadows outer variable [shadowVariable]
The text was updated successfully, but these errors were encountered: