Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32 IDF v4.2 compile fix #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CalebProvost
Copy link

Using char for c_in limits it to 8-bit boundaries. Updated to unsigned int for 32-bit processes.

ESP32 compile error resolved:

unishox2.c:576:46: error: array subscript has type 'char' [-Werror=char-subscripts]
         ol = append_code(out, ol, usx_code_94[c_in], &state, usx_hcodes, usx_hcode_lens);

Using char for c_in limits it to 8-bit boundaries. Updated to unsigned int for 32-bit processes.
@siara-cc
Copy link
Owner

Hi, Thank you for the PR. I am still making some improvements to unishox2.c. So I will take care of your problem while I am at it. I am thinking of fixing at the point where the compiler throws error using a typecast instead of changing the datatype of c_in to favor 8-bit machines out there.

@siara-cc
Copy link
Owner

@CalebProvost This has been fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants