Include esp_random.h #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an issue where a compiler warning (-Wimplicit-function-declaration) causes build breaks.
|
Hi, I apologize for the late response. Please see this post: #18 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where a compiler warning (-Wimplicit-function-declaration) causes build breaks. esp_random is used without a declaration, which causes the aforementioned warning
We have a -Werror build and we are using IDF v5, which caused a break in our build, including esp_random should fix that.
From what I understand, "esp_spi_flash" is also deprecated in favor of spi_flash_mmap in IDF v5, and I think it would be good to include "spi_flash_mmap" instead, but I left that out as I don't know if you guys would be willing for that
Thank you, and have a great day!