Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include esp_random.h #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include esp_random.h #17

wants to merge 1 commit into from

Conversation

term-est
Copy link

@term-est term-est commented May 9, 2023

Fix an issue where a compiler warning (-Wimplicit-function-declaration) causes build breaks. esp_random is used without a declaration, which causes the aforementioned warning

We have a -Werror build and we are using IDF v5, which caused a break in our build, including esp_random should fix that.

From what I understand, "esp_spi_flash" is also deprecated in favor of spi_flash_mmap in IDF v5, and I think it would be good to include "spi_flash_mmap" instead, but I left that out as I don't know if you guys would be willing for that

Thank you, and have a great day!

Fix an issue where a compiler warning (-Wimplicit-function-declaration) causes build breaks.
@siara-cc
Copy link
Owner

siara-cc commented Jun 8, 2023

Hi, I apologize for the late response. Please see this post: #18 (comment)
I don't use ESP-IDF that much and it will take me time to fix it for ESP-IDF 5, so if you think including spi_flash_mmap or spi_flash as mentioned in the above post is recommended, is it possible to update this PR?
Also is it possible to make this conditional using #ifdef to support older ESP-IDF versions?
I will merge this once I hear back from you. Thanks!

@antusystem antusystem mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants